The Cloudron access group alone was not enough: the app's own allowlist still
403'd every non-admin, so a steward with panel access saw nothing. Read is now
any authenticated identity Cloudron admitted to the app; write (balances,
credits, guest invites) stays with ADMIN_USERNAMES, enforced on every POST.
The page says which role you have and hides write controls when read-only.
The Members table's Allowance column printed the uniform $15 balance, which
is the total, not what the member still has. It now computes
max(balance - spend, 0) client-side from the two served fields (no series
summed in the browser), keeps its allowance-only class so it still hides in
All-time mode, and reads "Allowance left" with a title saying it is a budget,
not OC dues.
The Remaining column (allowance + credits - spend, a credit figure) is
replaced by Dues: the member's current Open Collective contribution level,
rendered $10/mo / $120/yr and '—' when the portal has no readable level.
Dues sorts by dues_amount with unknowns last, and carries no balance-col, so
it stays visible in both modes.
tests/check-page-js.sh now stubs classList/parentElement so a harness can
observe the mode toggle; admin-panel-dues-harness.js pins the subtraction,
floor, dues text, null handling, sort and 10-cell column count in both modes;
tests/test_member_table_columns.py pins the header/row alignment.
In All-time mode the Remaining *cell* carried remaining-only and hid, while its
header did not — so every column after it sat under the wrong heading and the
reset dates appeared under Remaining. The header now carries the same class its
cell does. Also widened the loading row's colspan to the real column count.
Fixing portal_post only closed half of it: portal_get still turned any non-200
from the portal into a 502, so a refusal or a rate limit on a read path would
have arrived as a gateway error as well. Both helpers now pass the portal's own
status and detail through.
portal_post collapsed every non-2xx upstream response into HTTPException(502), so
a plain rate limit ("Too many requests. Slow down.") reached the operator as
"Could not send guest access (502)": a gateway failure, for a condition that
clears in a minute and whose message said exactly that.
The status now passes through, so a 429 arrives as a 429 with the portal's own
words.
* source 'oc-incognito' gets its own chip. It read as plain "OC" — true as far as
it goes (they are an OC subscriber) but it hides what matters operationally:
email matching cannot see them, so their orders match by OC slug.
* The Admin section's spend column said "All-time spend" in BOTH modes, so in
balance mode the header described data that was not in the table. Now "Spend".
Kept the panel's own 'co-op's own share' line — that is the operator-account
breakdown only this app can see. The headline figure is now the shared one.
Money was both a tab and a metric of Trends — two doors to one chart, which is
what "not consistent" looks like from the outside. The tab is gone; the metric
stays, and the nav is Members · Model usage · Trends.
Period wording now matches the dashboard exactly: 30 days · 90 days · All time.
Titles come from the shared module (Members · Requests · Spend · Money · Energy ·
Carbon), so both apps offer the same six options in the same order.
The whole UI is one inline <script> with no ETag/Last-Modified and no cache
directive. After the 2026-11-13 fix deploy, a browser holding the previous copy
would keep running the dead script and make a fixed app look broken. The page is
cheap; serve it no-store.
The metric buttons were built with an inline handler inside PAGE_HTML:
+ " onclick=\"setTrendMetric('" + def.id + "')">" + ...
In a plain triple-quoted Python string `\"` is just `"`, so the SERVED JS read
+ " onclick="setTrendMetric('" + ...
— the string closes at `onclick=` and the rest is a syntax error. The whole
script died at that line: no fetches, no tables, no charts. Just the shell.
Two failures compounded:
1. The line itself (a Python-escape mistake, from a patch script that turned
`\\"` into `\"`).
2. The gate certified it. tests/check-page-js.sh sliced PAGE_HTML out of the
SOURCE TEXT between the triple quotes, so it checked the escapes as typed
while the app served them INTERPRETED — a page nobody was ever served.
node --check on that text says OK.
Fixes:
* buildMetricButtons() emits data-metric attributes and the row gets ONE
delegated click listener. No inline handlers, so no quote escape can break
the page again — and the wiring is testable.
* The gate now reads PAGE_HTML with ast.literal_eval: the string Python
actually serves. Proof it works: with the new gate, the pre-fix source FAILS
node --check for both apps; the fixed tree passes.
* The stub element gained stateful attributes and addEventListener/__fire, so
the harness can prove a click reaches setTrendMetric (and that a miss does
nothing).
* The chart harness's "series name is the chart title" assertion now compares
against the shared definition instead of a title that no longer exists.
Found by rendering the served page in a real browser, which is the only check
that could have caught it: the console said
Uncaught SyntaxError: Unexpected identifier 'setTrendMetric' @802:24
Money was its own tab with its own renderers (renderMoney, renderMoneyCumulative,
renderMoneyDaily, renderMoneyLegend), its own period and spend-mode toggles, and
its own titles. It is now a metric of Trends like the others: the definitions come
from CoOpChart.CHART_METRICS, the chart is drawn by the shared renderChart(), and
the Money tab is a shortcut into Trends with that metric selected.
Removed: TREND_CONF, trendVal, trendLabel, the four money renderers, the
period/spend-mode toggles (the single Period row governs every metric now) — 5.1k
chars of duplicate chart code. Added: METRIC_SOURCE (which fetch each metric
needs), buildMetricButtons() (buttons rendered from the shared list, so the panel
and dashboard describe the same charts in the same order), and the metric-aware
renderTrends() that delegates.
The daily token-spend view is now the shared "spend" metric — the same numbers the
metrics endpoint already served, so nothing is lost by dropping the second source.
No caption under the money chart, as before.
Harness rewritten for the new path (it drove renderMoney): invariants preserved —
2 cumulative polylines + single-point balance marker, shared tooltip host, legend
that IS the definition's series list, 5 ascending ticks with the top clearing the
max, 30-day slice. New: every shared metric has a button, and a metric with no
source says so instead of drawing another chart. Tests green (page JS, pins,
guest guard).
The tooltip machinery, axis steps, frames, bars, lines and hover targets move
to the canonical shared module (ops-docs scripts/shared/coop_chart.js,
byte-identical copy spliced into PAGE_HTML at import). PROOF of no visual
change: rendered innerHTML captured across 21 chart states (5 trend metrics x
3 ranges, 2 money modes x 3 periods) is byte-identical pre/post refactor.
CI: oidc + chart sync pins added to the pipeline; vendored check-page-js.sh
splices the module into the extracted page JS.
- app/oidc.py is now a byte-identical copy of the canonical module
(ops-docs: scripts/shared/oidc_client.py); this app's identity (logger
name, session cookie, session salt) is set via oidc.configure() in
main.py with the app's historical values, so existing sessions survive.
tests/test_oidc_sync.py pins the copy to the canonical revision.
- Guests list: the pill CONSUMES the portal-served `state` (the single
invited-vs-active derivation now lives in the portal and is tested
there). The local active-flag re-derivation is deleted — the shim is
first-served-field-wins (state → guest_status), so the previous payload
shape renders identically during a portal rollback. Guests harness
extended: invited-wins-over-ledger-active, served expired, and a
payload with neither field renders NO derived pill text.
Prefer the portal's derived state on the guest row: 'invited' (pale-blue
pill, awaiting-setup tooltip) while the Cloudron invite is un-accepted;
ledger status stays the fallback for older payloads. Display only.
The portal provisions member invites immediately (approval gate removed
2026-11-08), so the panel drops the Guest requests tab (queue, decisions,
badge and their JS) and the approve/reject API hops. Kept: the Guests list
(member-invited guests show inviter, credits, expiry, status, same as
admin-created ones) and the duplicate-send guard, now fed by the portal's
GET /admin/guest-ledger (ledger only — no pending key). Test updated: the
guard no longer has a pending branch; a legacy pending-shaped payload is
inert.
The operator could never tell what a submit did: the only outcome message was
the top flash, off-screen from the mid-page form, and a portal refusal left
the fields filled with nothing visible where the operator was looking.
- invite card now carries its own persistent status line (same palette as
.flash): success 'Invite sent to <email> — expires <date>.' with the fields
cleared; any refusal/failure shown plainly with the fields KEPT.
- button held disabled ('Sending…') for the whole request, restored after.
- flash(): clear the previous timer so a message shown soon after another is
not hidden by the first message's timeout.
- SERVER-SIDE duplicate guard (guest_duplicate_refusal, pure + unit-tested):
/api/provision-guest refuses 409 before any portal call when an ACTIVE
guest for the email exists ('A guest account for <email> already exists')
or a PENDING request awaits the decision ('awaits activation'). Holds for
any client; the portal's own one-guest-per-recipient guard stays behind it.
- admin-panel-invite-harness.js pins the whole behavior.
Final operator preference: the standard form is the guest's email
(required) plus an OPTIONAL display name, labelled 'Their name
(optional)'. The name passes through to provisioning as the initial
display name (the Cloudron path fills only empty names and never
overwrites one the guest sets at setup); an empty name is never derived
from the email.
Replaces the tab-bar form (email + name + inviting-member inputs, which
overflowed a narrow frame) with the standard form: a card in the members
view — 'Invite a guest', a single required email input, a 'Send invite'
button. No name field (the guest chooses their own at Cloudron setup) and
no inviter field: the portal records the co-op's ADMIN account and applies
no monthly cap to admin invites. Form submits on Enter; full-width input
and button under 600px. Removed the dead member-email datalist.
New Guest requests tab: the pending queue (inviter + recipient + name
visible, Approve/Reject per row with confirms), recent decisions, and the
guests ledger with every status pill — pending vs approved in one view.
Approve fires the portal's full guest pipeline through
/admin/guest-requests/{id}/approve (every guard re-runs); reject tells the
inviting member 'not approved' in their own dashboard trail. The tab badge
carries the pending count; the queue refetches on every visit and after
every decision so a row is never stale.
The Send-gift control sits in the members-view toolbar: recipient email +
name + inviting member (datalist of member emails), proxied to the portal's
/admin/provision-gift which enforces the abuse rules and returns clear
refusals. Gift rows carry the 'gift' pill in the Source column (inviter +
expiry in the tooltip); the pre-built Guests section shows inviter, expiry,
credits and ledger status as columns once the portal payload carries
account_type.
The operator removed all caveats from the finance chart. Gone: the
money-caption element, the caveat/stale/errors caption rendering, the
.legend 'history begins' suffix and the orphaned CSS. Chart, legend keys,
series and toggles untouched; balance_history_start stays in the payload.
Harness now asserts no caveat text renders in any mode.
New Money tab beside Trends, fed by the portal's /admin/money-series
(hourly-cached server-side). One fetch at full range; period (30/90/all)
and spend-mode (cumulative/daily) toggles re-render client-side.
- Cumulative mode: three lines — Revenue (OC contributions, green),
Token spend (blue), OC balance (amber). NULL balance days render as a
gap (the OC API exposes only the CURRENT balance; history accrues from
daily snapshots from the deploy date onward — stated in the caption
and in the balance legend key).
- Daily mode: token spend per day as bars (spend-only; the other series
are cumulative and would need a second axis).
- Money ticks use the 1/2/5 x 10^k rule; tooltips reuse the shared
chart-tip helper (all three series listed per day).
- The caption is a deliberate exception to the no-caption chart rule:
the operator asked for the honest data-history limits in the UI.
- Harness: tests/money-chart-harness.js (axis invariants, gap handling,
daily bars, period slice, single-point balance).
One shared, hand-rolled helper (no library, no CDN) replaces the native
SVG <title> tooltips: charts stamp data-tip-host/data-tip-i on their data
elements and register their exact values from the data arrays; one
delegated pointer listener set serves every chart, so re-renders need no
re-binding and new charts (the upcoming finance chart) join chart-by-chart
by following the two-step contract documented in the helper. The box is a
fixed-position div with pointer-events:none, clamped inside the viewport
(no edge flicker, never intercepts clicks); touch shows on tap/drag and
hides on release. Harness: admin-panel-chart-harness.js (exact values,
gap handling, clamping, multi-series contract) run via check-page-js.sh.
The co-op's panels do not put text under the pills. Replace the long
state-reason caption (and the over-long pill tooltip) with a single short
pill (in_grace -> 'grace') whose tooltip is one short line, matching the
existing pill vocabulary.
The Members Status column now renders the portal's per-member 'state'
(active / in grace / awaiting / inactive) instead of the raw active flag, with
the portal's reason shown beneath the pill. The portal owns the state; the panel
only displays it. Non-active states keep the member's access.
The totals cards showed spend that silently mixed members and the co-op's own
operator accounts. /admin/overview now returns operator_spend and
operator_all_time_spend beside the totals, and each spend card names its scope
("members + co-op's own") and states the co-op's own share beneath it, so no
figure has to be guessed at.
The agents table rendered the raw team spend field and labelled it 'Spend (30 days)', but that field is cycle-only and resets at budget_reset_at — for the agent teams, the 1st of the month. On 1 November both bot accounts therefore displayed as zeroed. It now prefers the all-time figure the portal supplies, and the label says what it shows.
- Agent accounts render without the "agent:" prefix, since the section header already
says Agents. The full alias is still in the payload as `alias`.
- The admin/operator table now carries the same columns as the agents table — Account,
Type, Spend, Budget — with Type "admin" and Budget "—". Activated and Reset are gone:
neither applies to an account that is not a member and has no member budget cycle.
Bot and sandbox teams had real spend that the panel structurally could not show: they
have no member row, and the all-time query filtered to member:% teams. They now appear
in an "Agents" category beside Admin, fed by the portal's new `agents` list, with spend
and budget. Kept out of member counts and member aggregates — a collective expense,
like the operator accounts already were.
Read-only on the reporting path; the set-balance and set-credits write routes are
untouched.
Two more metrics on the same chart, from the portal's new energy_wh and co2e_g
daily columns.
- Energy in watt-hours, carbon in grams CO2e, both for the day shown.
- Continuous metrics use the 1/2/5 axis rule (not the integer rule reserved for
counts), so energy ticks read 500 Wh rather than being rounded to whole
people-style numbers.
- Labels carry units, so a reader never has to guess what the axis measures.
- Same measured-vs-estimated provenance as the data layer: GreenPT models use
facts fitted from their own impact API, everyone else a labelled proxy. The
docs page on estimation is still to be written; the factor table and its
sources are in metrics_snapshot.py.
Harness extended: one bar per measured day for each, no NaN in markup, and axis
labels matching ^[\d,]+(\.\d+)? (Wh|g)$ so a unit prefix or a forced integer
axis fails the build.
Nathan: the disclaimers are not necessary, especially now that reporting is in
place going forward — and then, on the status line under it: remove that too.
Gone from both apps: the explanatory note paragraph, its per-metric config
strings, the status line ("55 days - 2 not measured"), the now-orphaned CSS for
both, and the gaps counter that only fed the status line. The period toggles
still say what range is on screen, so no information is lost.
The harness assertions that described the status line are replaced by stronger
ones: the rendered chart must contain no caveat text at all, and the 30-day view
must still end at the most recent measured day.
Nathan: the members axis should be whole numbers, since it counts people. It
was drawing fractional ticks (19.17 people) because the 1.08 headroom factor
fed straight into the label math.
Ticks now come from a step, with the axis top set to step x 4, so labels land
on round numbers:
- counts (members, requests): whole numbers, rounded up to a half power of ten
(requests read 3,000, not 2,888). Never below 1, so a near-empty series still
gets an integer axis rather than fractions.
- money: the 1/2/5 x 10^k rule, so ticks read $10.00 rather than $4.92.
Rendered now: members 0 | 20 | 40 | 60 | 80; requests 0 | 3,000 | 6,000 |
9,000 | 12,000; spend $0.00 | $10.00 | $20.00 | $30.00 | $40.00.
The node harness gained assertions for this, checked geometrically (tick values
ascend while their screen positions descend, the zero tick sits lowest, ticks
are evenly spaced) rather than assuming a text order, so a fractional
people-axis or a misplaced label fails before a deploy.
Nathan asked to see a chart. The portal now owns a daily metrics series
(metrics_daily, written 03:15 UTC by the portal's own scheduler); this is the
first surface to read it.
- New route /api/metrics proxies the portal's /admin/metrics/series (admin
token stays server-side, same pattern as /api/model-usage).
- New Trends tab, added to switchView in the same edit (every view toggled
there must be shown/hidden there). Lazy: the series loads on first visit, so
the panel's initial load is unchanged.
- Metric toggle (Members / Spend / Requests) and period toggle (30 / 90 / all
time). Fetched once at the widest range and re-rendered client-side, so the
toggles never refetch.
- Inline SVG, hand-rolled: no chart library, no CDN, no external dependency.
Colours come from the panel's existing CSS vars, so it matches the rest.
- Gaps are drawn as gaps. A NULL metric means "not measured" and the line
deliberately breaks rather than drawing through a day we never recorded
(backfilled members_active is NULL every day, by design). The sub-line says
how many days are unmeasured.
- Members shows the cumulative total; spend and requests are per-day bars.
Verified against the live 55-day series with a node harness running the real
page functions: 22 checks, including that a NULL breaks the line into two runs,
that no NaN reaches the markup, that the toggles do not refetch, and that the
SVG carries no hardcoded hex.