capsite/toybox: vats have ids, not names; ingress by mount
createVat (POST / on the admin socket) makes a vat with newUniqueId and returns its id, which addresses it only there. A vat is reachable only where it is mounted: ?mount=<labels> on each start, as ?egress= is granted; absent means none. The ingress reads a request's labels from its query string, plus a Toybox-Labels header for secret ones (a URL ends up in logs and Referers). It routes to the vat whose mount labels the request carries, every one: stricter than Flower's no-conflict match, since an ingress client holds no constrained handle and a label it omits must not match. Registration keeps Flower's rule, so a mount must conflict with every other and no request can carry two. The app keeps the whole path and sees its connection labels in Toybox-Connection-Labels. A vat from before ids lives at idFromName(name). PUT /by-name/<name> reaches it on the admin socket; it stays unreachable from outside until mounted. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
f0557d29d6
commit
8d8900d84d
6 files changed
+307
-69
No files matched your search
+110
-40
@@ -29,26 +29,42 @@ const accepting = (opts) =>
|
||||
s.on("error", () => resolve(false));
|
||||
});
|
||||
|
||||
/** @param {string} socketPath the admin socket; holding it is the authority to install */
|
||||
const makeAdmin = (socketPath) => ({
|
||||
install: (vat, src, labels) =>
|
||||
/**
|
||||
* The admin socket: holding it is the authority to create and upgrade vats.
|
||||
*
|
||||
* @param {string} socketPath
|
||||
*/
|
||||
const makeAdmin = (socketPath) => {
|
||||
const send = (method, path, src, { egress, mount } = {}) =>
|
||||
new Promise((resolve, reject) => {
|
||||
const grant = typeof labels === "string" ? labels : JSON.stringify(labels);
|
||||
const path = labels ? `/${vat}?egress=${encodeURIComponent(grant)}` : `/${vat}`;
|
||||
const req = request({ socketPath, path, method: "PUT", agent: false }, (res) => {
|
||||
const q = new URLSearchParams();
|
||||
if (egress) q.set("egress", typeof egress === "string" ? egress : JSON.stringify(egress));
|
||||
if (mount) q.set("mount", JSON.stringify(mount));
|
||||
const req = request({ socketPath, path: `${path}?${q}`, method, agent: false }, (res) => {
|
||||
let body = "";
|
||||
res.on("data", (c) => (body += c));
|
||||
res.on("end", () => resolve(body.trim()));
|
||||
res.on("end", () => resolve(res.statusCode === 200 ? JSON.parse(body) : { status: res.statusCode, body }));
|
||||
});
|
||||
req.on("error", reject);
|
||||
req.end(src);
|
||||
}),
|
||||
});
|
||||
});
|
||||
return {
|
||||
/** `createVat`: a new vat, reachable only by its id here, and by its mount */
|
||||
create: (src, grants) => send("POST", "/", src, grants),
|
||||
upgrade: (vat, src, grants) => send("PUT", `/${vat}`, src, grants),
|
||||
/** a vat from before ids */
|
||||
byName: (name, src, grants) => send("PUT", `/by-name/${name}`, src, grants),
|
||||
};
|
||||
};
|
||||
|
||||
/** @param {string} base the public origin */
|
||||
const makePublic = (base) => ({
|
||||
get: async (path) => (await fetch(`${base}/${path}`)).text(),
|
||||
put: async (vat, src) => (await fetch(`${base}/${vat}`, { method: "PUT", body: src })).status,
|
||||
get: async (pathAndQuery, headers = {}) => {
|
||||
const resp = await fetch(`${base}${pathAndQuery}`, { headers });
|
||||
return { status: resp.status, text: await resp.text(), referrerPolicy: resp.headers.get("Referrer-Policy") };
|
||||
},
|
||||
text: async (pathAndQuery) => (await fetch(`${base}${pathAndQuery}`)).text(),
|
||||
put: async (pathAndQuery, src) => (await fetch(`${base}${pathAndQuery}`, { method: "PUT", body: src })).status,
|
||||
});
|
||||
|
||||
/**
|
||||
@@ -137,72 +153,124 @@ after(async () => {
|
||||
await rm(dir, { recursive: true, force: true });
|
||||
});
|
||||
|
||||
test("a vat with no code is 404", async () => {
|
||||
assert.equal(await pub.get("nobody"), "no code installed\n");
|
||||
const at = (name) => ({ mount: { vat: name } });
|
||||
|
||||
test("nothing mounted: 404", async () => {
|
||||
assert.equal((await pub.get("/?vat=nobody")).status, 404);
|
||||
});
|
||||
|
||||
test("install, run, upgrade: the app's state carries over", async () => {
|
||||
assert.match(await admin.install("alice", await app("counter-v1.js")), /^[0-9a-f]{64}$/);
|
||||
assert.equal(await pub.get("alice"), "v1 count 1\n");
|
||||
assert.equal(await pub.get("alice"), "v1 count 2\n");
|
||||
await admin.install("alice", await app("counter-v2.js"));
|
||||
assert.equal(await pub.get("alice"), "v2 count 3\n");
|
||||
test("createVat returns an id and a code hash; unmounted, the vat is unreachable", async () => {
|
||||
const { vat, hash } = await admin.create(await app("counter-v1.js"));
|
||||
assert.match(vat, /^[0-9a-f]{64}$/);
|
||||
assert.match(hash, /^[0-9a-f]{64}$/);
|
||||
assert.equal((await pub.get("/")).status, 404);
|
||||
});
|
||||
|
||||
test("install, run, upgrade: the app's state carries over; every start states its grants", async () => {
|
||||
const { vat } = await admin.create(await app("counter-v1.js"), at("alice"));
|
||||
assert.equal(await pub.text("/?vat=alice"), "v1 count 1\n");
|
||||
assert.equal(await pub.text("/?vat=alice"), "v1 count 2\n");
|
||||
await admin.upgrade(vat, await app("counter-v2.js"), at("alice"));
|
||||
assert.equal(await pub.text("/?vat=alice"), "v2 count 3\n");
|
||||
await admin.upgrade(vat, await app("counter-v2.js"));
|
||||
assert.equal((await pub.get("/?vat=alice")).status, 404);
|
||||
await admin.upgrade(vat, await app("counter-v2.js"), at("alice"));
|
||||
assert.equal(await pub.text("/?vat=alice"), "v2 count 4\n");
|
||||
});
|
||||
|
||||
test("vats don't share state", async () => {
|
||||
await admin.install("carol", await app("counter-v1.js"));
|
||||
assert.equal(await pub.get("carol"), "v1 count 1\n");
|
||||
await admin.create(await app("counter-v1.js"), at("bob"));
|
||||
await admin.create(await app("counter-v1.js"), at("carol"));
|
||||
assert.equal(await pub.text("/?vat=bob"), "v1 count 1\n");
|
||||
assert.equal(await pub.text("/?vat=carol"), "v1 count 1\n");
|
||||
});
|
||||
|
||||
test("an app gets no fetch", async () => {
|
||||
await admin.install("bob", await app("try-fetch.js"));
|
||||
assert.match(await pub.get("bob"), /^fetch refused: This worker is not permitted to access the internet/);
|
||||
await admin.create(await app("try-fetch.js"), at("bob-fetch"));
|
||||
assert.match(await pub.text("/?vat=bob-fetch"), /^fetch refused: This worker is not permitted to access the internet/);
|
||||
});
|
||||
|
||||
test("the public port can't install code", async () => {
|
||||
assert.equal(await pub.put("mallory", "export class App {}"), 404);
|
||||
assert.equal(await pub.get("mallory"), "no code installed\n");
|
||||
assert.equal(await pub.put("/", "export class App {}"), 404);
|
||||
});
|
||||
|
||||
test("code and state survive a restart", async () => {
|
||||
await admin.install("dave", await app("counter-v1.js"));
|
||||
assert.equal(await pub.get("dave"), "v1 count 1\n");
|
||||
test("the path is the app's; its labels are the mount's and the request's together", async () => {
|
||||
await admin.create(await app("show-labels.js"), at("lab"));
|
||||
const got = await pub.get("/a/b?vat=lab&page=2");
|
||||
assert.equal(got.text, `/a/b ${JSON.stringify({ vat: "lab", page: "2" })}\n`);
|
||||
assert.equal(got.referrerPolicy, "no-referrer");
|
||||
});
|
||||
|
||||
test("a label given twice is a 400", async () => {
|
||||
assert.equal((await pub.get("/?vat=lab&vat=lab")).status, 400);
|
||||
});
|
||||
|
||||
test("mounts that could both match a request are refused", async () => {
|
||||
const src = await app("show-labels.js");
|
||||
await admin.create(src, at("x"));
|
||||
const narrower = await admin.create(src, { mount: { vat: "x", n: "2" } });
|
||||
assert.equal(narrower.status, 409);
|
||||
assert.match(narrower.body, /overlaps another/);
|
||||
// no key in common with the {vat} mounts: ?vat=x&app=x would carry both
|
||||
assert.equal((await admin.create(src, { mount: { app: "x" } })).status, 409);
|
||||
assert.match((await admin.create(src, { mount: { vat: "y", n: "2" } })).vat, /^[0-9a-f]{64}$/);
|
||||
});
|
||||
|
||||
test("a secret label: in a header, not the URL; omitting it doesn't match", async () => {
|
||||
const secret = "k".repeat(43);
|
||||
await admin.create(await app("show-labels.js"), { mount: { vat: "safe", key: secret } });
|
||||
assert.equal((await pub.get("/?vat=safe")).status, 404);
|
||||
assert.equal((await pub.get("/?vat=safe&key=wrong")).status, 404);
|
||||
const got = await pub.get("/?vat=safe", { "Toybox-Labels": JSON.stringify({ key: secret }) });
|
||||
assert.equal(got.status, 200);
|
||||
});
|
||||
|
||||
test("code, state, and mount survive a restart", async () => {
|
||||
await admin.create(await app("counter-v1.js"), at("dave"));
|
||||
assert.equal(await pub.text("/?vat=dave"), "v1 count 1\n");
|
||||
await server.stop();
|
||||
server = await startToybox("main", port, "local");
|
||||
assert.equal(await pub.get("dave"), "v1 count 2\n");
|
||||
assert.equal(await pub.text("/?vat=dave"), "v1 count 2\n");
|
||||
});
|
||||
|
||||
test("a vat from before ids is unreachable until the admin mounts it by its old name", async () => {
|
||||
await admin.byName("old", await app("counter-v1.js"));
|
||||
assert.equal((await pub.get("/?vat=old")).status, 404);
|
||||
await admin.byName("old", await app("counter-v1.js"), at("old"));
|
||||
assert.equal(await pub.text("/?vat=old"), "v1 count 1\n");
|
||||
});
|
||||
|
||||
const probe = (vat, target, { ws, constrain } = {}) =>
|
||||
pub.get(
|
||||
`${vat}?url=${encodeURIComponent(`http://${target}/`)}` +
|
||||
pub.text(
|
||||
`/?vat=${vat}&url=${encodeURIComponent(`http://${target}/`)}` +
|
||||
(ws ? "&ws=1" : "") +
|
||||
(constrain ? `&constrain=${encodeURIComponent(JSON.stringify(constrain))}` : ""),
|
||||
);
|
||||
|
||||
test("a vat granted a host reaches it through the switchboard: fetch and WebSocket", async () => {
|
||||
await admin.install("erin", await app("egress-probe.js"), echoLabels);
|
||||
await admin.create(await app("egress-probe.js"), { ...at("erin"), egress: echoLabels });
|
||||
assert.equal(await probe("erin", echo.host), "got: plain ok\n");
|
||||
assert.equal(await probe("erin", echo.host, { ws: true }), "echo: hello\n");
|
||||
});
|
||||
|
||||
test("same code, no grant: no egress", async () => {
|
||||
await admin.install("frank", await app("egress-probe.js"));
|
||||
await admin.create(await app("egress-probe.js"), at("frank"));
|
||||
assert.equal(await probe("frank", echo.host), "no egress granted\n");
|
||||
});
|
||||
|
||||
test("a grant is an object, not ambient: the global fetch still throws", async () => {
|
||||
await admin.install("heidi", await app("try-fetch.js"), echoLabels);
|
||||
assert.match(await pub.get("heidi"), /^fetch refused: This worker is not permitted to access the internet/);
|
||||
await admin.create(await app("try-fetch.js"), { ...at("heidi"), egress: echoLabels });
|
||||
assert.match(await pub.text("/?vat=heidi"), /^fetch refused: This worker is not permitted to access the internet/);
|
||||
});
|
||||
|
||||
test("the switchboard refuses what a grant doesn't cover", async () => {
|
||||
await admin.install("grace", await app("egress-probe.js"), { host: "127.0.0.1", port: "1" });
|
||||
await admin.create(await app("egress-probe.js"), { ...at("grace"), egress: { host: "127.0.0.1", port: "1" } });
|
||||
assert.match(await probe("grace", echo.host), /^got: egress refused: .*egress to 127\.0\.0\.1 not granted/);
|
||||
assert.match(await probe("grace", echo.host, { ws: true }), /^no websocket: 403 egress refused: .*not granted/);
|
||||
});
|
||||
|
||||
test("a vat can narrow its grant, but not contradict it", async () => {
|
||||
await admin.install("ivan", await app("egress-probe.js"), { scheme: "http" });
|
||||
await admin.create(await app("egress-probe.js"), { ...at("ivan"), egress: { scheme: "http" } });
|
||||
assert.equal(await probe("ivan", echo.host, { constrain: echoLabels }), "got: plain ok\n");
|
||||
assert.match(
|
||||
await probe("ivan", echo.host, { constrain: { scheme: "https" } }),
|
||||
@@ -211,7 +279,7 @@ test("a vat can narrow its grant, but not contradict it", async () => {
|
||||
});
|
||||
|
||||
test("a grant stored before labels, a bare host:port, still works", async () => {
|
||||
await admin.install("kim", await app("egress-probe.js"), echo.host);
|
||||
await admin.create(await app("egress-probe.js"), { ...at("kim"), egress: echo.host });
|
||||
assert.equal(await probe("kim", echo.host), "got: plain ok\n");
|
||||
});
|
||||
|
||||
@@ -226,9 +294,11 @@ test("a toybox holding only the public handle can't reach localhost, whatever th
|
||||
const other = await startToybox("public-only", port2, "public");
|
||||
try {
|
||||
const admin2 = makeAdmin(join(dir, "public-only", "admin.sock"));
|
||||
await admin2.install("judy", await app("egress-probe.js"), echoLabels);
|
||||
await admin2.create(await app("egress-probe.js"), { ...at("judy"), egress: echoLabels });
|
||||
const before = echo.hits();
|
||||
const got = await (await fetch(`http://127.0.0.1:${port2}/judy?url=${encodeURIComponent(`http://${echo.host}/`)}`)).text();
|
||||
const got = await (
|
||||
await fetch(`http://127.0.0.1:${port2}/?vat=judy&url=${encodeURIComponent(`http://${echo.host}/`)}`)
|
||||
).text();
|
||||
// workerd reports the public network's refusal (restrictPeers) to JS only as "internal error"
|
||||
assert.match(got, /^got: egress refused: /);
|
||||
assert.equal(echo.hits(), before);
|
||||
|
||||
Reference in new issue
Block a user