dckc/captoys
1
0 Fork 0
Code Issues Pull Requests 4 Actions Packages Projects Releases Wiki Activity

capsite/toybox: no encoder object in module scope

Browse Source 
A module-level TextEncoder is a mutable object every importer shares.
Keep only its encode method, bound and hardened; the encoder itself is
unreachable. The code hash uses it too.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
dckcandClaude Opus 5.5 committed 2026-10-13 21:44:29 -05:00
1 parent 7fcd251261
commit 28b1c3c9d3
1 file changed
+4 -3
Download Patch File Download Diff File Expand all files Collapse all files
toybox/supervisor.js
+4 -3
View File
@@ -55,7 +55,7 @@ export class Vat extends DurableObject {
* @returns {Promise<string>} the code's SHA-256, hex * @returns {Promise<string>} the code's SHA-256, hex
*/ */
async start(src, egress, kind = "app") { async start(src, egress, kind = "app") {
const hash = hex(await crypto.subtle.digest("SHA-256", new TextEncoder().encode(src))); const hash = hex(await crypto.subtle.digest("SHA-256", encodeUtf8(src)));
const { sql } = this.ctx.storage; const { sql } = this.ctx.storage;
sql.exec("INSERT OR IGNORE INTO bundle VALUES (?, ?)", hash, src); sql.exec("INSERT OR IGNORE INTO bundle VALUES (?, ?)", hash, src);
sql.exec("INSERT OR REPLACE INTO current VALUES (0, ?)", hash); sql.exec("INSERT OR REPLACE INTO current VALUES (0, ?)", hash);
@@ -164,7 +164,8 @@ export class Egress extends WorkerEntrypoint {
const VAT_ADMIN = "vatAdmin"; const VAT_ADMIN = "vatAdmin";
/** The swissnum of an OCapN vat's bootstrap (see vat-runtime.js). */ /** The swissnum of an OCapN vat's bootstrap (see vat-runtime.js). */
const VAT_SWISSNUM = "vat"; const VAT_SWISSNUM = "vat";
const encoder = new TextEncoder(); /** UTF-8 bytes of a string: the method alone, so no encoder object is in module scope. */
const encodeUtf8 = harden(TextEncoder.prototype.encode.bind(new TextEncoder()));
/** /**
* The vatAdmin: an OCapN peer, and the router through which every OCapN * The vatAdmin: an OCapN peer, and the router through which every OCapN
@@ -209,7 +210,7 @@ export class VatAdmin extends DurableObject {
#enliven(designator, swissnum) { #enliven(designator, swissnum) {
return this.ocapn.enlivenSturdyRef( return this.ocapn.enlivenSturdyRef(
this.ocapn.makeSturdyRef(locationOf(designator), swissnumFromBytes(encoder.encode(swissnum))), this.ocapn.makeSturdyRef(locationOf(designator), swissnumFromBytes(encodeUtf8(swissnum))),
); );
} }