oc-incognito: take the slug from the member's own row
ci/woodpecker/push/woodpecker Pipeline was canceled
ci/woodpecker/push/woodpecker Pipeline was canceled
Setting the source was not enough, and verification is what caught it: mmoya still produced no allowance decision at all. The reconciler gets a member's OC slug from the member INDEX — which is keyed by email, and DROPS anyone whose profile hides its email. So `oc_slug` came back empty, the member fell into "not in the live Open Collective member list — cannot verify payment", and was counted as skipped. An oc-incognito member would have been "not manual" and still not reconciled: a nicer label over the same hole. For source oc-incognito the slug now comes from the member's own row, which is the same key fetch_member_orders() groups orders by — the whole reason matching can work for these people. The test pins the fallback, not just the source.
This commit is contained in:
1 parent
66a770ae10
commit
b1022eb02a
2 files changed
+17
No files matched your search
@@ -93,6 +93,10 @@ recon = src[src.index("async def reconcile_allowances"):]
|
||||
recon = recon[:recon.index("def ", recon.index("for row in rows"))]
|
||||
check('member_source(email, conn) == "manual"' in recon,
|
||||
"the reconciliation skips only source == manual")
|
||||
check('member_source(email, conn) == "oc-incognito"' in recon and "oc_slug = slug" in recon,
|
||||
"an oc-incognito member takes the OC slug from their own row — the index cannot give it "
|
||||
"(it drops anyone without an email), and without a slug the reconciler skips them as "
|
||||
"'cannot verify payment'")
|
||||
check("in MANUAL_MEMBERS" not in recon,
|
||||
"and no longer keys on the raw list (an oc-incognito member must not be skipped)")
|
||||
check("not is_manual_member(email)" in src,
|
||||
|
||||
Reference in new issue
Block a user