From a8200fdf54ff84c3fc19d43b645b95268d9ea73a Mon Sep 17 00:00:00 2001 From: Inferencebot Date: Wed, 4 Nov 2026 17:31:11 +0000 Subject: [PATCH] allowances: correct the dormant-yearly note (collective order list is complete; a member's account.orders spans collectives) --- app/main.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/app/main.py b/app/main.py index d162b12..31945b3 100644 --- a/app/main.py +++ b/app/main.py @@ -4200,10 +4200,13 @@ def _payment_verdict(orders: list[dict], cycle_start: datetime, (7-day slack) is paid, before it is the remind path. DORMANT ON TODAY'S DATA: as of 2026-11-04 the collective has no yearly orders - (104 orders: 88 MONTHLY, 16 ONETIME, 0 YEARLY — verified per member account, - since a member's own yearly order does not appear in the collective-level - order list). The yearly branch is defensive robustness for a tier we may add - later; it is not a fix for any current member. `now` is injectable for tests. + (104 orders: 88 MONTHLY, 16 ONETIME, 0 YEARLY — read from the collective-level + order list, which is complete for our collective). The yearly branch is + defensive robustness for a tier we may add later; it is not a fix for any + current member. Attribution caution: one member's `account.orders` spans EVERY + collective they back, so an order's OWNING collective (`toAccount`) must be + checked before it is credited to us — a foreign YEARLY order (social.coop) was + once misread as a yearly payer here. `now` is injectable for tests. """ now = now or datetime.now(timezone.utc)