fix: the panel served a page whose script never ran
ci/woodpecker/push/woodpecker Pipeline was successful
ci/woodpecker/push/woodpecker Pipeline was successful
The metric buttons were built with an inline handler inside PAGE_HTML:
+ " onclick=\"setTrendMetric('" + def.id + "')">" + ...
In a plain triple-quoted Python string `\"` is just `"`, so the SERVED JS read
+ " onclick="setTrendMetric('" + ...
— the string closes at `onclick=` and the rest is a syntax error. The whole
script died at that line: no fetches, no tables, no charts. Just the shell.
Two failures compounded:
1. The line itself (a Python-escape mistake, from a patch script that turned
`\\"` into `\"`).
2. The gate certified it. tests/check-page-js.sh sliced PAGE_HTML out of the
SOURCE TEXT between the triple quotes, so it checked the escapes as typed
while the app served them INTERPRETED — a page nobody was ever served.
node --check on that text says OK.
Fixes:
* buildMetricButtons() emits data-metric attributes and the row gets ONE
delegated click listener. No inline handlers, so no quote escape can break
the page again — and the wiring is testable.
* The gate now reads PAGE_HTML with ast.literal_eval: the string Python
actually serves. Proof it works: with the new gate, the pre-fix source FAILS
node --check for both apps; the fixed tree passes.
* The stub element gained stateful attributes and addEventListener/__fire, so
the harness can prove a click reaches setTrendMetric (and that a miss does
nothing).
* The chart harness's "series name is the chart title" assertion now compares
against the shared definition instead of a title that no longer exists.
Found by rendering the served page in a real browser, which is the only check
that could have caught it: the console said
Uncaught SyntaxError: Unexpected identifier 'setTrendMetric' @802:24
This commit is contained in:
1 parent
88bf95ed27
commit
c3f5a326c2
3 files changed
+68
-10
No files matched your search
@@ -26,7 +26,11 @@ renderTrends();
|
||||
const pts = chartTipData["trend-body"];
|
||||
assert(Array.isArray(pts) && pts.length === 4, "registry: one point per row (got " + (pts && pts.length) + ")");
|
||||
assert(pts[0].label === "2026-11-01", "registry label is the row's exact day");
|
||||
assert(pts[0].series[0][0] === "Spend per day", "registry series name is the chart title");
|
||||
// The tooltip's series name is the SHARED definition's title (coop_chart.js
|
||||
// line ~373: a single-series metric labels itself with def.title). Asserting
|
||||
// the invariant, not the string that happened to be there before the port.
|
||||
assert(pts[0].series[0][0] === metricDef("spend").title,
|
||||
"the tooltip series name is the shared definition's title (got " + pts[0].series[0][0] + ")");
|
||||
// EXACT values: the tooltip string must be the data value through the
|
||||
// panel's own formatter — never a pixel-derived estimate.
|
||||
assert(pts[0].series[0][1] === "$12.34", "exact spend for 11-01 (got " + pts[0].series[0][1] + ")");
|
||||
@@ -88,5 +92,24 @@ renderTrends();
|
||||
assert(!!L["pointercancel"], "touch cancel hides the tooltip");
|
||||
}
|
||||
|
||||
// ---- the metric buttons are DELEGATED, so prove a click reaches setTrendMetric ----
|
||||
// (An inline onclick inside PAGE_HTML is where a quote escape silently kills the
|
||||
// whole page: it happened, and it shipped, because the gate read the raw source
|
||||
// text instead of the string Python serves. Delegation removes that trap — and
|
||||
// this is the check that the wiring still works.)
|
||||
{
|
||||
buildMetricButtons();
|
||||
const rowEl = document.getElementById("trend-metrics");
|
||||
assert(!!(rowEl.__handlers && rowEl.__handlers.click),
|
||||
"the metric row has a delegated click listener");
|
||||
setTrendMetric("members");
|
||||
const fired = rowEl.__fire("click", { target: { closest: () => ({ getAttribute: () => "money" }) } });
|
||||
assert(trendMetric === "money",
|
||||
"clicking a metric button selects that metric (got " + trendMetric + ")");
|
||||
setTrendMetric("members");
|
||||
rowEl.__fire("click", { target: { closest: () => null } });
|
||||
assert(trendMetric === "members", "a click that misses a button is ignored");
|
||||
}
|
||||
|
||||
console.log("HARNESS OK: chart tooltips (bars, line, gaps, exact values, clamping, multi-series)");
|
||||
process.exit(0);
|
||||
Reference in new issue
Block a user