charts refactored onto the shared coop_chart.js module — rendering unchanged
ci/woodpecker/push/woodpecker Pipeline was successful
ci/woodpecker/push/woodpecker Pipeline was successful
The tooltip machinery, axis steps, frames, bars, lines and hover targets move to the canonical shared module (ops-docs scripts/shared/coop_chart.js, byte-identical copy spliced into PAGE_HTML at import). PROOF of no visual change: rendered innerHTML captured across 21 chart states (5 trend metrics x 3 ranges, 2 money modes x 3 periods) is byte-identical pre/post refactor. CI: oidc + chart sync pins added to the pipeline; vendored check-page-js.sh splices the module into the extracted page JS.
This commit is contained in:
1 parent
c31f124bd1
commit
5ea2be7247
5 files changed
+412
-243
No files matched your search
+14
-2
@@ -38,8 +38,20 @@ html = src[start:src.index('"""', start)]
|
||||
blocks = re.findall(r"<script>(.*?)</script>", html, re.S)
|
||||
if len(blocks) != 1:
|
||||
sys.exit(f"expected exactly 1 <script> block in PAGE_HTML, found {len(blocks)}")
|
||||
open(sys.argv[2], "w").write(blocks[0])
|
||||
print(f"extracted {len(blocks[0])} chars of page JS from PAGE_HTML")
|
||||
js = blocks[0]
|
||||
# Splice the shared chart module exactly as the app does at import time, so
|
||||
# the checked/eval'd JS is what actually serves. The placeholder is a comment,
|
||||
# and a missing module file leaves the placeholder in place (the harness then
|
||||
# fails loudly on the missing CoOpChart instead of silently checking stale JS).
|
||||
from pathlib import Path
|
||||
placeholder = "/*@@CHART_MODULE@@*/"
|
||||
if placeholder in js:
|
||||
module = Path(sys.argv[1]).resolve().parent / "coop_chart.js"
|
||||
if module.exists():
|
||||
js = js.replace(placeholder, module.read_text())
|
||||
print(f"spliced shared chart module ({module.name}) into the extracted page JS")
|
||||
open(sys.argv[2], "w").write(js)
|
||||
print(f"extracted {len(js)} chars of page JS from PAGE_HTML")
|
||||
PY
|
||||
|
||||
node --check "$TMP/page.js"
|
||||
|
||||
@@ -0,0 +1,60 @@
|
||||
#!/usr/bin/env python3
|
||||
"""coop_chart.js sync pin — the repo copy is byte-identical to the canonical
|
||||
module, and main.py splices it into the served page.
|
||||
|
||||
WHY THIS EXISTS
|
||||
app/coop_chart.js is a byte-identical copy of the canonical module
|
||||
(co-op/ops-docs repo: scripts/shared/coop_chart.js) — the single source for
|
||||
the hand-rolled chart rendering + hover tooltips both UIs ship. This test
|
||||
pins the copy to the canonical revision recorded below: ANY hand edit to
|
||||
app/coop_chart.js breaks the pin and goes red. To change the module, edit
|
||||
the canonical file and run ops-docs/scripts/sync-chart-module.sh, which
|
||||
re-copies and re-pins both repos in one step (check-chart-sync.py is the
|
||||
pre-deploy gate).
|
||||
|
||||
Generated by sync-chart-module.sh — do not edit by hand.
|
||||
|
||||
Run: python3 tests/test_chart_sync.py
|
||||
"""
|
||||
import hashlib
|
||||
import sys
|
||||
from pathlib import Path
|
||||
|
||||
ROOT = Path(__file__).resolve().parent.parent
|
||||
CANONICAL_SHA256 = "a029fd40189acc38b8b218921c56e24e0208c8c8e0ab550a320bbd57449f5fed"
|
||||
SPLICE = 'PAGE_HTML = PAGE_HTML.replace("/*@@CHART_MODULE@@*/", CHART_MODULE_JS)'
|
||||
|
||||
failures = []
|
||||
|
||||
copy = ROOT / "app" / "coop_chart.js"
|
||||
if not copy.exists():
|
||||
failures.append("app/coop_chart.js missing")
|
||||
else:
|
||||
got = hashlib.sha256(copy.read_bytes()).hexdigest()
|
||||
if got == CANONICAL_SHA256:
|
||||
print(f"ok - app/coop_chart.js matches the pinned canonical revision ({got[:16]}…)")
|
||||
else:
|
||||
failures.append(
|
||||
"app/coop_chart.js DRIFTED from the pinned canonical revision\n"
|
||||
f" pinned {CANONICAL_SHA256}\n"
|
||||
f" actual {got}\n"
|
||||
" fix: edit the canonical module (ops-docs: scripts/shared/coop_chart.js) "
|
||||
"and run ops-docs/scripts/sync-chart-module.sh — never hand-edit the copy.")
|
||||
|
||||
main_src = (ROOT / "app" / "main.py")
|
||||
if not main_src.exists():
|
||||
failures.append("app/main.py missing")
|
||||
else:
|
||||
msrc = main_src.read_text()
|
||||
if SPLICE not in msrc:
|
||||
failures.append(
|
||||
"app/main.py does not splice the shared chart module into PAGE_HTML:\n"
|
||||
f" expected literal: {SPLICE}")
|
||||
if 'parent / "coop_chart.js"' not in msrc:
|
||||
failures.append("app/main.py does not load app/coop_chart.js")
|
||||
|
||||
if failures:
|
||||
print()
|
||||
print("FAILED: " + ", ".join(failures))
|
||||
sys.exit(1)
|
||||
print("chart sync pin: OK")
|
||||
Reference in new issue
Block a user