panel: exact-value hover tooltips on every chart

One shared, hand-rolled helper (no library, no CDN) replaces the native
SVG <title> tooltips: charts stamp data-tip-host/data-tip-i on their data
elements and register their exact values from the data arrays; one
delegated pointer listener set serves every chart, so re-renders need no
re-binding and new charts (the upcoming finance chart) join chart-by-chart
by following the two-step contract documented in the helper. The box is a
fixed-position div with pointer-events:none, clamped inside the viewport
(no edge flicker, never intercepts clicks); touch shows on tap/drag and
hides on release. Harness: admin-panel-chart-harness.js (exact values,
gap handling, clamping, multi-series contract) run via check-page-js.sh.
This commit is contained in:
inference-bot committed 2026-11-08 01:47:56 +00:00
1 parent 831569391b
commit 254f701416
2 files changed
+205 -2

No files matched your search

+113 -2
View File
@@ -283,6 +283,14 @@ PAGE_HTML = """<!DOCTYPE html>
.trend-title { font-weight: 700; font-size: 14px; color: var(--ink); }
.trend-body svg { display: block; width: 100%; height: auto; overflow: visible; }
.trend-empty { color: var(--muted); font-size: 13px; margin: 28px 0; text-align: center; }
/* Chart hover tooltip: one shared box for every chart, positioned near the
pointer and clamped inside the viewport. pointer-events:none so it can
never intercept a click on the chart underneath. */
.chart-tip { position: fixed; display: none; z-index: 60; pointer-events: none; background: #fff; border: 1px solid var(--border); border-radius: 8px; box-shadow: 0 2px 10px rgba(45,51,39,0.16); padding: 7px 10px; font-size: 12px; max-width: 280px; }
.chart-tip .tip-day { color: var(--muted); font-size: 11px; margin-bottom: 3px; }
.chart-tip .tip-row { display: flex; justify-content: space-between; gap: 14px; }
.chart-tip .tip-row span { color: var(--muted); }
.chart-tip .tip-row b { color: var(--ink); font-variant-numeric: tabular-nums; }
@media (max-width: 600px) { .trend-controls { gap: 10px; } .trend-card { padding: 12px 10px; } }
.num { font-variant-numeric: tabular-nums; }
.remaining-col { font-weight: 700; color: var(--green-deep); background: #eaf3ea; }
@@ -574,14 +582,116 @@ function trendLabel(v) {
return Number(v).toLocaleString();
}
// ---- Chart tooltips: exact values on hover ----
// One shared helper serves EVERY chart on the panel; no library, no CDN.
// Contract for a chart (two steps, then tooltips just work):
// 1. At render time, stamp each hoverable data element with
// data-tip-host="<hostId>" and data-tip-i="<index into the data>"
// 2. registerChartTips("<hostId>", points) with one point per index:
// { label: "2026-11-07", series: [["Spend", "$12.34"], ["Revenue", "$40.00"]] }
// Values MUST come from the chart's own data arrays (exact), never
// pixel-estimated, and `series` carries EVERY series at that x.
// A single delegated listener set on `document` then serves all charts, so
// re-rendering a chart's innerHTML needs no re-binding, and a new chart (the
// finance chart, any future one) joins chart-by-chart as it renders. The box
// is a fixed-position div with pointer-events:none, clamped inside the
// viewport so it never flickers off-screen or swallows a click.
const chartTipData = {}; // hostId -> [{ label, series: [[name, value], ...] }]
let chartTipBox = null; // the singleton tooltip div, created on first use
let chartTipCur = null; // { host, idx } the point currently shown
function registerChartTips(hostId, points) { chartTipData[hostId] = points; }
function chartTipTarget(el) {
return el && el.closest ? el.closest("[data-tip-host]") : null;
}
function hideChartTip() {
chartTipCur = null;
if (chartTipBox) chartTipBox.style.display = "none";
}
function showChartTip(hostId, idx, cx, cy) {
const p = (chartTipData[hostId] || [])[idx];
if (!p) { hideChartTip(); return; }
if (!chartTipBox) {
chartTipBox = document.createElement("div");
chartTipBox.className = "chart-tip";
document.body.appendChild(chartTipBox);
}
const same = chartTipCur && chartTipCur.host === hostId && chartTipCur.idx === idx;
if (!same) {
let html = '<div class="tip-day">' + esc(p.label) + "</div>";
for (let s = 0; s < p.series.length; s++) {
html += '<div class="tip-row"><span>' + esc(p.series[s][0]) + "</span><b>" + esc(p.series[s][1]) + "</b></div>";
}
chartTipBox.innerHTML = html;
chartTipCur = { host: hostId, idx: idx };
}
chartTipBox.style.display = "block";
moveChartTip(cx, cy);
}
// Position beside the pointer, flipped/clamped so the box stays fully inside
// the viewport at chart edges.
function moveChartTip(cx, cy) {
if (!chartTipBox || chartTipBox.style.display === "none") return;
const pad = 12, m = 4;
const w = chartTipBox.offsetWidth, h = chartTipBox.offsetHeight;
let x = cx + pad, y = cy + pad;
if (x + w > window.innerWidth - m) x = cx - pad - w;
if (x < m) x = m;
if (y + h > window.innerHeight - m) y = cy - pad - h;
if (y < m) y = m;
chartTipBox.style.left = x + "px";
chartTipBox.style.top = y + "px";
}
document.addEventListener("pointerover", (e) => {
const t = chartTipTarget(e.target);
if (!t) return;
showChartTip(t.getAttribute("data-tip-host"), parseInt(t.getAttribute("data-tip-i"), 10), e.clientX, e.clientY);
});
document.addEventListener("pointermove", (e) => {
const t = chartTipTarget(e.target);
if (!t) return;
const host = t.getAttribute("data-tip-host");
const idx = parseInt(t.getAttribute("data-tip-i"), 10);
const cur = chartTipCur;
if (!cur || cur.host !== host || cur.idx !== idx) showChartTip(host, idx, e.clientX, e.clientY);
else moveChartTip(e.clientX, e.clientY);
});
document.addEventListener("pointerout", (e) => {
const from = chartTipTarget(e.target);
if (!from) return;
const to = e.relatedTarget ? chartTipTarget(e.relatedTarget) : null;
if (!to || to.getAttribute("data-tip-host") !== from.getAttribute("data-tip-host")) hideChartTip();
});
// Basic touch: tap/drag shows and follows, release hides it after a beat.
document.addEventListener("pointerup", (e) => {
if (e.pointerType === "touch") setTimeout(hideChartTip, 1600);
});
document.addEventListener("pointercancel", hideChartTip);
// Scrolling or resizing moves the chart under a fixed-position box - hide
// rather than show a tooltip for the wrong point.
window.addEventListener("scroll", hideChartTip, { passive: true });
window.addEventListener("resize", hideChartTip);
function renderTrends() {
const host = $("trend-body");
if (!host || !trendsData) return;
hideChartTip();
const conf = TREND_CONF[trendMetric];
const rows = trendDays === 0 ? trendsData : trendsData.slice(-trendDays);
$("trend-title").textContent = conf.title;
const vals = rows.map(trendVal);
// Register the EXACT values the tooltips will show, straight from the data
// rows - one point per index, in the same order as the stamped elements.
registerChartTips("trend-body", rows.map((row, i) => ({
label: row.day,
series: [[conf.title, trendLabel(vals[i])]]
})));
const have = vals.filter(v => v !== null && v !== undefined);
if (have.length < 2) {
host.innerHTML = "<p class=trend-empty>Not enough history yet.</p>";
@@ -615,7 +725,7 @@ function renderTrends() {
const v = vals[i];
if (v === null || v === undefined) continue;
const yy = yAt(v);
parts.push('<rect x="' + (xAt(i) - bw / 2) + '" y="' + yy + '" width="' + bw + '" height="' + Math.max(0.6, baseY - yy) + '" fill="var(--green-mid)"><title>' + rows[i].day + ": " + trendLabel(v) + "</title></rect>");
parts.push('<rect x="' + (xAt(i) - bw / 2) + '" y="' + yy + '" width="' + bw + '" height="' + Math.max(0.6, baseY - yy) + '" fill="var(--green-mid)" data-tip-host="trend-body" data-tip-i="' + i + '"></rect>');
}
} else {
// Break the line into contiguous measured runs: a gap stays a gap.
@@ -634,7 +744,7 @@ function renderTrends() {
}
for (let i = 0; i < n; i++) {
if (vals[i] === null || vals[i] === undefined) continue;
parts.push('<circle cx="' + xAt(i) + '" cy="' + yAt(vals[i]) + '" r="7" fill="transparent"><title>' + rows[i].day + ": " + trendLabel(vals[i]) + "</title></circle>");
parts.push('<circle cx="' + xAt(i) + '" cy="' + yAt(vals[i]) + '" r="7" fill="transparent" data-tip-host="trend-body" data-tip-i="' + i + '"></circle>');
}
}
@@ -676,6 +786,7 @@ function clearArrows(table, sortState) {
function switchView(view) {
currentView = view;
hideChartTip();
$('table-members').style.display = view === 'members' ? '' : 'none';
$('table-models').style.display = view === 'models' ? '' : 'none';
// The Admin section is a members-view category; hide it in the Models view